-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[high cardinality queries] track OOM on trace item table and time series endpoints #6814
base: master
Are you sure you want to change the base?
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: snuba/clickhouse/native.py
Did you find this useful? React with a 👍 or 👎 |
25f5fe8
to
eb45416
Compare
eb45416
to
e55a1a2
Compare
053bda5
to
b3cd798
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
7266cc6
to
9f7e8a8
Compare
9f7e8a8
to
d18c096
Compare
except QueryException as e: | ||
if e.extra[ | ||
"code" | ||
] == 241 or "DB::Exception: Memory limit (for query) exceeded" in str(e): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to match on the code and the string? Or do we need to look for the full message as opposed to just Memory limit
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do either. I'm kind of making the assumption here that ClickHouse's OOM error will always be 241. As an extra measure I'm also doing string matching with "DB::EXception: Memory..."
I'm not string matching for the full message since the full message can be extremely long and differs for every error, but it seems like "DB::Exception: Memory limit (for query) exceeded" is the same in every OOM error
291b242
to
d4b777c
Compare
d4b777c
to
1fb3d27
Compare
c16d8de
to
2c8d44e
Compare
2c8d44e
to
6e8f00a
Compare
https://github.com/getsentry/projects/issues/463