Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flags): add hasFlags to project serializer #83216

Merged
merged 3 commits into from
Jan 10, 2025
Merged

feat(flags): add hasFlags to project serializer #83216

merged 3 commits into from
Jan 10, 2025

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Jan 9, 2025 •
edited
Loading

serializes project.hasFlags field so the frontend can use the value

relates to https://github.com/getsentry/team-replay/issues/499

@michellewzhang michellewzhang requested a review from a team as a code owner January 9, 2025 23:46
@michellewzhang michellewzhang requested review from a team and aliu39 January 9, 2025 23:46
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2025
cmanallen
cmanallen requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the OpenAPI examples (any where you see hasReplays add hasFlags)

sentry/src/sentry/apidocs/examples/team_examples.py

Line 238 in 132dcb6

"hasReplays": False,

@michellewzhang
Copy link
Member Author

Just need to update the OpenAPI examples (any where you see hasReplays add hasFlags)

sentry/src/sentry/apidocs/examples/team_examples.py

Line 238 in 132dcb6

"hasReplays": False,

i believe i updated all the instances - the open api tests were failing otherwise

cmanallen
cmanallen approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michellewzhang I still see the openapi diff failing. Any idea why that's happening?

@michellewzhang
Copy link
Member Author

@michellewzhang I still see the openapi diff failing. Any idea why that's happening?

that one always fails when there's an api change (you can see it's marked as optional) - the one that should pass is backend / api docs test (pull_request)

@michellewzhang michellewzhang merged commit 023a5ba into master Jan 10, 2025
48 of 49 checks passed
@michellewzhang michellewzhang deleted the mz/serialize-flag branch January 10, 2025 18:32
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@michellewzhang @andrewshie-sentry
feat(flags): add hasFlags to project serializer (#83216)
9f5aacf 
serializes `project.hasFlags` field so the frontend can use the value

relates to getsentry/team-replay#499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmanallen cmanallen cmanallen approved these changes

@aliu39 aliu39 Awaiting requested review from aliu39

@JoshFerge JoshFerge Awaiting requested review from JoshFerge

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michellewzhang @cmanallen