Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Route to org settings forms correctly #83209

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Jan 9, 2025

Splitting up the path and the query/hash and only calling replaceRouterParams once

Fixes an issue where routing to some settings like "Open Team Membership" would take you to the wrong page.

Splitting up the path and the query/hash and only calling replaceRouterParams once
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8491 1 8490 2
View the top 1 failed tests by shortest run time
FormSource can find a form field
Stack Traces | 1.02s run time
Error: expect(jest.fn()).toHaveBeenLastCalledWith(...expected)

Expected: ObjectContaining {"results": [ObjectContaining {"item": {"description": "test-help", "field": {"help": "test-help", "label": "Test Field", "name": "test-field", "type": "text"}, "resultType": "field", "route": "/route/", "sourceType": "field", "title": "Test Field", "to": "/route/#test-field"}}]}
Received
       1: {"isLoading": false, "results": []}
->     2: {"isLoading": false, "results": [{"item": {"description": "test-help", "field": {"help": "test-help", "label": "Test Field", "name": "test-field", "type": "text"}, "resultType": "field", "route": "/route/", "sourceType": "field", "title": "Test Field", "to": {"hash": "#test-field", "pathname": "/route/"}}, "matches": [{"indices": [[0, 1]], "key": "title", "value": "Test Field"}, {"indices": [[0, 1]], "key": "description", "value": "test-help"}], "refIndex": 0, "score": 0.000007568328950209746}]}

Number of calls: 2

Ignored nodes: comments, script, style
...
    at .../search/sources/formSource.spec.tsx:46:64
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:594:17)
    at processTimers (node:internal/timers:529:7)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Jan 11, 2025

Bundle Report

Changes will increase total bundle size by 137.38kB (0.44%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 31.02MB 137.38kB (0.44%) ⬆️

@scttcper scttcper merged commit 6a98798 into master Jan 13, 2025
42 checks passed
@scttcper scttcper deleted the scttcper/settings-search-routes branch January 13, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants