Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devservices): Cutover to using devservices in CI #83179

Closed
Closed
119 changes: 0 additions & 119 deletions .github/actions/test-setup-sentry-devservices/action.yml

This file was deleted.

1 change: 1 addition & 0 deletions .github/file-filters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ api_docs: &api_docs
backend_any_type: &backend_any_type
- *backend_all
- *api_docs
- 'devservices/**'

migrations_added:
- added:
Expand Down
15 changes: 12 additions & 3 deletions .github/workflows/acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ concurrency:
env:
SEGMENT_DOWNLOAD_TIMEOUT_MINS: 3
NODE_OPTIONS: '--max-old-space-size=4096'
# Disables sentry reporting for devservices
DISABLE_SENTRY: 1
CHARTCUTERIE_CONFIG_PATH: ${{ github.workspace }}/config/chartcuterie
SNUBA_NO_WORKERS: 1

jobs:
files-changed:
Expand Down Expand Up @@ -110,12 +114,12 @@ jobs:
make build-chartcuterie-config

- name: Setup sentry env
# TODO(hubertdeng): Rename to setup-sentry when all repos are no longer using ./.github/actions/setup-sentry
uses: ./.github/actions/setup-sentry
id: setup
with:
snuba: true
chartcuterie: true
pg-version: ${{ matrix.pg-version }}
use-new-devservices: true
mode: acceptance-ci

- name: Run acceptance tests (#${{ steps.setup.outputs.matrix-instance-number }} of ${{ steps.setup.outputs.matrix-instance-total }})
run: make run-acceptance
Expand All @@ -142,6 +146,11 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
commit_sha: ${{ github.event.pull_request.head.sha }}

- name: Inspect failure
if: failure()
run: |
devservices logs

acceptance-required-checks:
# this is a required check so we need this job to always run and report a status.
if: always()
Expand Down
60 changes: 46 additions & 14 deletions .github/workflows/backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ concurrency:
# hack for https://github.com/actions/cache/issues/810#issuecomment-1222550359
env:
SEGMENT_DOWNLOAD_TIMEOUT_MINS: 3
# Disables sentry reporting for devservices
DISABLE_SENTRY: 1
SNUBA_NO_WORKERS: 1

jobs:
files-changed:
Expand Down Expand Up @@ -52,10 +55,12 @@ jobs:
node-version-file: '.volta.json'

- name: Setup sentry python env
# TODO(hubertdeng): Rename to setup-sentry when all repos are no longer using ./.github/actions/setup-sentry
uses: ./.github/actions/setup-sentry
id: setup
with:
snuba: true
use-new-devservices: true
mode: default

- name: Run API docs tests
# install ts-node for ts build scripts to execute properly without potentially installing
Expand All @@ -64,6 +69,10 @@ jobs:
run: |
yarn add ts-node && make test-api-docs

- name: Inspect failure
if: failure()
run: devservices logs

backend-test:
if: needs.files-changed.outputs.backend == 'true'
needs: files-changed
Expand Down Expand Up @@ -91,18 +100,12 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup sentry env
# TODO(hubertdeng): Rename to setup-sentry when all repos are no longer using ./.github/actions/setup-sentry
uses: ./.github/actions/setup-sentry
id: setup
with:
redis_cluster: true
kafka: true
snuba: true
symbolicator: true
# Right now, we run so few bigtable related tests that the
# overhead of running bigtable in all backend tests
# is way smaller than the time it would take to run in its own job.
bigtable: true
pg-version: ${{ matrix.pg-version }}
use-new-devservices: true
mode: backend-ci

- name: Run backend test (${{ steps.setup.outputs.matrix-instance-number }} of ${{ steps.setup.outputs.matrix-instance-total }})
run: |
Expand All @@ -128,6 +131,10 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
commit_sha: ${{ github.event.pull_request.head.sha }}

- name: Inspect failure
if: failure()
run: devservices logs

backend-migration-tests:
if: needs.files-changed.outputs.backend == 'true'
needs: files-changed
Expand All @@ -142,11 +149,12 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup sentry env
# TODO(hubertdeng): Rename to setup-sentry when all repos are no longer using ./.github/actions/setup-sentry
uses: ./.github/actions/setup-sentry
id: setup
with:
snuba: true
pg-version: ${{ matrix.pg-version }}
use-new-devservices: true
mode: default

- name: run tests
run: |
Expand All @@ -161,6 +169,10 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
commit_sha: ${{ github.event.pull_request.head.sha }}

- name: Inspect failure
if: failure()
run: devservices logs

cli:
if: needs.files-changed.outputs.backend == 'true'
needs: files-changed
Expand All @@ -174,10 +186,12 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup sentry env
# TODO(hubertdeng): Rename to setup-sentry when all repos are no longer using ./.github/actions/setup-sentry
uses: ./.github/actions/setup-sentry
id: setup
with:
pg-version: ${{ matrix.pg-version }}
use-new-devservices: true
mode: migrations

- name: Run test
run: |
Expand All @@ -192,6 +206,10 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
commit_sha: ${{ github.event.pull_request.head.sha }}

- name: Inspect failure
if: failure()
run: devservices logs

requirements:
if: needs.files-changed.outputs.backend_dependencies == 'true'
needs: files-changed
Expand Down Expand Up @@ -239,10 +257,12 @@ jobs:
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup sentry env
# TODO(hubertdeng): Rename to setup-sentry when all repos are no longer using ./.github/actions/setup-sentry
uses: ./.github/actions/setup-sentry
id: setup
with:
pg-version: ${{ matrix.pg-version }}
use-new-devservices: true
mode: migrations

- name: Migration & lockfile checks
env:
Expand All @@ -251,6 +271,10 @@ jobs:
run: |
./.github/workflows/scripts/migration-check.sh

- name: Inspect failure
if: failure()
run: devservices logs

monolith-dbs:
if: needs.files-changed.outputs.backend == 'true'
needs: files-changed
Expand All @@ -264,8 +288,12 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup sentry env
# TODO(hubertdeng): Rename to setup-sentry when all repos are no longer using ./.github/actions/setup-sentry
uses: ./.github/actions/setup-sentry
id: setup
with:
use-new-devservices: true
mode: migrations

- name: Run test
run: |
Expand All @@ -290,6 +318,10 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
commit_sha: ${{ github.event.pull_request.head.sha }}

- name: Inspect failure
if: failure()
run: devservices logs

typing:
if: needs.files-changed.outputs.backend == 'true'
needs: files-changed
Expand Down
Loading
Loading