Skip to content

test: Normalize timezone during unit tests #7248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

lukasbestle
Copy link
Member

Description

Summary of changes

Always set timezone to UTC during PHPUnit tests

Reasoning

We have some tests that assume UTC in their expected values. If the timezone is set differently in php.ini, those tests would fail.

We have some tests that assume UTC in their expected values. If the timezone is set differently in `php.ini`, those tests would fail.
@lukasbestle lukasbestle added this to the 5.0.0 milestone May 27, 2025
@lukasbestle lukasbestle requested a review from a team May 27, 2025 19:38
@lukasbestle lukasbestle self-assigned this May 27, 2025
@bastianallgeier bastianallgeier merged commit 0fdffdd into v5/develop May 28, 2025
12 checks passed
@bastianallgeier bastianallgeier deleted the v5/fix/phpunit-timezone branch May 28, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants