Skip to content

fix: Writer empty state when value gets changed #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

fix: Writer empty state when value gets changed #7247

merged 1 commit into from
May 28, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented May 27, 2025 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • Writer input: set isEmpty when value changes externally

Changelog

Fixes

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 5.0.0 milestone May 27, 2025
@distantnative distantnative self-assigned this May 27, 2025
@distantnative distantnative requested a review from a team May 27, 2025 19:19
@distantnative distantnative linked an issue May 27, 2025 that may be closed by this pull request
[v5] Block previews: Placeholder still visible when editing text in block drawer #7246
Closed
@distantnative distantnative marked this pull request as ready for review May 27, 2025 19:19
@bastianallgeier bastianallgeier merged commit d4a03f5 into v5/develop May 28, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the v5.0/fix/7246-writer-input-is-empty branch May 28, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[v5] Block previews: Placeholder still visible when editing text in block drawer
2 participants
@distantnative @bastianallgeier