Media firewall 3: Introduce media subhashes #7195
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
/media/site/abcdefghij-1234567890
), there is now another directory layer (e.g./media/site/abcdefghij-1234567890/bcdefghija
) to separate all individual files (the original and each thumb)Reasoning
/media/site/abcdefghij-1234567890/file-120x.jpg
you could change the filename tofile.jpg
to access the original, which may not be intended by devs).Additional context
With the transitional and migration code, there shouldn't be a breaking impact to sites. But since there is already a lot going on in v5, I suggest we include this PR in 5.1 or 5.x. This ensures that users upgrading to v5 with a lot of media files and thumbs don't immediately run into performance problems when all those files are migrated.
Changelog
Enhancements
Deprecated
Breaking changes
None
Docs
None
Ready?
For review team