Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle #-directives as keywords in OpenFOAM files #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gerlero
Copy link
Owner

@gerlero gerlero commented Jan 8, 2025

Fixes #314

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (3ca383d) to head (3d215dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   87.04%   87.08%   +0.04%     
==========================================
  Files          15       15              
  Lines        1397     1402       +5     
==========================================
+ Hits         1216     1221       +5     
  Misses        181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerlero
Copy link
Owner Author

gerlero commented Jan 9, 2025

Waiting for the JOSS review process (openjournals/joss-reviews#7633) before merging these changes and making a new breaking release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding includeFunc in controlDict crashes FoamFile serialization
2 participants