Skip to content

[gluon-v2023.2.x] update ffac-ssid-changer and ffbs-collect-debug-info #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025

Conversation

ffmuc-bot[bot]
Copy link
Contributor

@ffmuc-bot ffmuc-bot bot commented Apr 26, 2025

Update modules for gluon-v2023.2.x branch
- Auto-generated by [create-pull-request][1]

aafd6b2 fix bug in ssid-changer introduced in lua rewrite
b25e816 add normal logging and only change ssid if it is not already set to offline
4e85ebf ffac-ssid-changer: reimplement in lua
d655b2b ffbs-collect-debug-info: collect routes for table 1 and policy routing rules

Supersedes #603

aafd6b2 fix bug in ssid-changer introduced in lua rewrite
2735fdc ci: sync linting to the version in gluon-packages
862167e Add .shellcheckrc
b37699a ffbs-mesh-vpn-parker: fix reading persistent_keepalive and typos
7611b92 ffbs-mesh-vpn-parker: Remove all wireguard interfaces on autoupdate
b25e816 add normal logging and only change ssid if it is not already set to offline
8b2e0ca ffbs-mesh-vpn-parker: fix shell word splitting
8d2d47c ffbs-parker-nextnode: use BuildPackageGluon instead of BuildPackage
4f321ed ffbs-mesh-vpn-parker: silence shellcheck errors due to /etc/rc.common
129fb2e ffbs-mesh-vpn-parker: fix shellcheck errors
b90d68b ffbs-mesh-vpn-parker: remove obsolete copyright copied from example
e57234c ffbs-mesh-vpn-parker: Drop files in /etc/rc.d
382049e ffbs-mesh-vpn-parker: Mark files in gluon/upgrade as executable
0a1beb4 ffbs-mesh-vpn-parker: Rename respondd-dependency
a320cf1 ffbs-mesh-vpn-parker: delete prefix6 firewall rule
b2e19a7 ffbs-mesh-vpn-parker: move parker pubkey to uci
2bc4460 ffbs-mesh-vpn-parker: place ipv4 wan routes into table 1
655959f ffbs-mesh-vpn-parker: configure unreachable routes
748d3e3 ffbs-mesh-vpn-parker: make sure wg-pubkey exists
de9b244 ffbs-mesh-vpn-parker: fix default parker config
46cc67c ffbs-mesh-vpn-parker: check uci for config_server
93415d0 ffbs-parker-nextnode: Change dependency direction to ffbs-parker-nodeconfig
285a6d5 Add ffbs-parker-nextnode
4e85ebf ffac-ssid-changer: reimplement in lua
d655b2b ffbs-collect-debug-info: collect routes for table 1 and policy routing rules
2c09555 ffac-web-dsl: initial package version
b54cbc1 ffac-dsl: initial package
e8b6ad3 ffbs-parker-respondd: Rename from ffbs-parker-nodeconfig-respondd
f6b8829 ffbs-parker-nodeconfig-respondd: Drop circular dependency
d77cc2d ffbs-mesh-vpn-parker: reduce nesting in noderoute
67e1468 Add ffbs-parker-nodeconfig-respondd
35b7dc7 ffbs-mesh-vpn-parker: Drop legacy route check
b4f01b6 fixes for luacheck
ca674f5 move luasrc around, fix wrong provider folder location
2f4d446 fix duplicate dependency
ca7eea1 make backwards compatible by providing former package name
c8460a6 rename ffbs-parker-nodeconfig to ffbs-mesh-vpn-parker
537609b add parker provider to ffbs-parker-nodeconfig
2f48599 ffbs-parker-nodeconfig: firewall: Allow respondd from all internal addr
f66665d ffbs-parker-nodeconfig: Get NTP server from site
94c4fe6 Add ffbs-parker-nodeconfig
@grische grische closed this Apr 26, 2025
@grische grische deleted the update-modules-gluon-v2023.2.x-1745656090 branch April 26, 2025 08:28
@grische grische restored the update-modules-gluon-v2023.2.x-1745656090 branch April 27, 2025 16:30
@grische grische reopened this Apr 27, 2025
@grische grische changed the title [gluon-v2023.2.x] update modules [gluon-v2023.2.x] update ffac-ssid-changer: reimplement in lua Apr 27, 2025
@grische grische added the backport gluon-main Backport to Gluon Main Branch label Apr 27, 2025
@grische grische changed the title [gluon-v2023.2.x] update ffac-ssid-changer: reimplement in lua [gluon-v2023.2.x] update ffac-ssid-changer and ffbs-collect-debug-info Apr 27, 2025
@T0biii
Copy link
Member

T0biii commented Apr 29, 2025

@grische is there a reason why this is still on draft?

@grische
Copy link
Contributor

grische commented Apr 29, 2025

@T0biii my ssid changer still did not seem to have triggered, despite the device being offline.
I haven't had time to look into it though.

@grische grische requested a review from Copilot May 12, 2025 16:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates modules to align with the gluon-v2023.2.x branch, including fixes for ssid-changer and updates to debug info collection.

  • Update commit hash for the community packages repository
  • Incorporate bug fixes from recent updates to ssid-changer
Comments suppressed due to low confidence (1)

modules:12

  • [nitpick] Please verify that the updated commit hash correctly aligns with the expected state of the community packages repository and has been validated via appropriate integration tests.
PACKAGES_COMMUNITY_COMMIT=a64fb18c5b0d00e8d384c32a0a97b27a3b055448

@grische
Copy link
Contributor

grische commented May 12, 2025

@T0biii my ssid changer still did not seem to have triggered, despite the device being offline.
I haven't had time to look into it though.

I was able to reproduce twice but when I involved @maurerle I was unable to reproduce it anymore. Not sure what happened, but if I am the only affected, we can merge it.

@T0biii
Copy link
Member

T0biii commented May 12, 2025

@T0biii my ssid changer still did not seem to have triggered, despite the device being offline.
I haven't had time to look into it though.

I was able to reproduce twice but when I involved @maurerle I was unable to reproduce it anymore. Not sure what happened, but if I am the only affected, we can merge it.

as i dont have a wifi node i cant say anything about this

@grische
Copy link
Contributor

grische commented May 24, 2025

I'm unable to reproduce the issue. @T0biii should we merge it?

@T0biii
Copy link
Member

T0biii commented May 24, 2025

Sounds good, we also can rerun the Module Update

@T0biii T0biii marked this pull request as ready for review May 24, 2025 10:55
@T0biii T0biii requested review from maurerle and a team as code owners May 24, 2025 10:55
Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this took long enough. I'd like to avoid bringing in even more changes.

@grische grische merged commit 70e8e71 into gluon-v2023.2.x May 25, 2025
67 checks passed
@grische grische deleted the update-modules-gluon-v2023.2.x-1745656090 branch May 25, 2025 08:40
@ffmuc-bot
Copy link
Contributor Author

ffmuc-bot bot commented May 25, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport gluon-main Backport to Gluon Main Branch gluon-v2023.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants