fix: removed status draft and unpaid in sales quotes #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableksaju
reviewed
May 14, 2025
Comment on lines
43
to
+47
| if (this.doc instanceof SalesQuote && this.doc.isSubmitted) { | ||
| return ''; | ||
| } | ||
There was a problem hiding this comment.
Unnecessary check — can be removed
Comment on lines
59
to
62
| ReturnIssued: this.t`Return Issued`, | ||
| '': '', | ||
| }[this.status]; | ||
| }, |
There was a problem hiding this comment.
' ': ' ', is unnecessary — remove
Comment on lines
80
to
82
| ReturnIssued: 'green', | ||
| '': 'gray', | ||
| }; |
There was a problem hiding this comment.
'': 'gray', is unnecessary — remove
Comment on lines
84
to
87
| function getStatus(doc: Doc) { | ||
| if (doc.notInserted) { | ||
| if (doc.schemaName !== ModelNameEnum.SalesQuote && doc.notInserted) { | ||
| return 'Draft'; | ||
| } |
There was a problem hiding this comment.
No need for the update — revert to original notInserted check.
Comment on lines
108
to
+112
| if (doc.schemaName === ModelNameEnum.SalesQuote) { | ||
| return doc.isSubmitted ? '' : 'NotSubmitted'; | ||
| } | ||
There was a problem hiding this comment.
Unnecessary check — can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.