Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligned SignUp button #800 #801

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Aligned SignUp button #800 #801

wants to merge 2 commits into from

Conversation

arpitgupta1906
Copy link

@arpitgupta1906 arpitgupta1906 commented Nov 16, 2020 •
edited
Loading

issue: #800

Before
Screenshot from 2020-11-16 20-45-41

After
Screenshot from 2020-11-16 20-45-07

Raunaksingh100
Raunaksingh100 reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@Raunaksingh100 Raunaksingh100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add the issue number in your pr descption

@arpitgupta1906
Copy link
Author

plz add the issue number in your pr descption

Done.

NaviRocker
NaviRocker suggested changes Nov 25, 2020
View reviewed changes
css/custom.css Outdated
@@ -64,6 +64,7 @@
.newsletter-name{
padding-right: 0px;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add unwanted lines

index.html Outdated
<a target="_default" href="https://freelayers.net/subscription?f=bOkSmWCUaboPsmMjkCrPp13VzBnEGyddTZqn892vAexe11eV4hzvYeDZI892X1cewRwyClP6MespDGz8OkG94MtW9Q
" class="btn">Singup Here</a>
" class="btn">SignUp Here</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use "Signup"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@Devansh252
Copy link

Is this issue still open ??

Raunaksingh100
Raunaksingh100 approved these changes Dec 7, 2020
View reviewed changes
css/custom.css Outdated
@@ -64,6 +64,7 @@
.newsletter-name{
padding-right: 0px;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why extra space ??

@Raunaksingh100 Raunaksingh100 mentioned this pull request Feb 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaviRocker NaviRocker NaviRocker requested changes

@Raunaksingh100 Raunaksingh100 Raunaksingh100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arpitgupta1906 @Devansh252 @NaviRocker @Raunaksingh100