Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw away prepared statements on terminate #8137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Jan 24, 2025

Description

When we get a TERMINATE message from the frontend, we need to DEALLOCATE all currently prepared statements because the new client will not know about them.

Also, bumps to the latest patch version of pglite.

Fixes part of #8133, specifically the SQL Error: pq: prepared statement "1" already exists errors

Scenarios Tested

After an error that leads to a terminate message, future queries still work as normal.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.11%. Comparing base (774d3f0) to head (4a4df1b).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
src/emulator/dataconnect/pgliteServer.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8137      +/-   ##
==========================================
+ Coverage   51.10%   51.11%   +0.01%     
==========================================
  Files         423      423              
  Lines       29636    29703      +67     
  Branches     6063     6078      +15     
==========================================
+ Hits        15144    15184      +40     
- Misses      13134    13154      +20     
- Partials     1358     1365       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants