Skip to content

Clean up templates #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 17, 2025
Merged

Conversation

IanVS
Copy link

@IanVS IanVS commented Mar 12, 2025

Note: this is built on top of #13, which should be merged first.

This cleans up the TS/JS project templates:

  • Adds "bindings" to all the tsconfig / jsconfig files
  • Removes tsconfig.node.json, which only matters if you use tsc -b, which our templates do not.
  • Adds the wails plugin to all templates
  • Removes the build config from templates. This feels like it should be a separate PR / discussion from the event typing
  • Renames the wails plugin to match more closely with vite plugin conventions.
  • Adds a couple of missing vite-env.d.ts files to the templates

IanVS added 5 commits March 12, 2025 10:08
They only do anything if you use `tsc --build`, which we don't.
So we might as well reduce the complexity.
@fbbdev fbbdev self-requested a review March 17, 2025 06:03
@fbbdev fbbdev merged commit 463c3b9 into fbbdev:v3-alpha-feature/event-types Mar 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants