Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: new(prow): pigeon integration #1020

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

wip: new(prow): pigeon integration #1020

wants to merge 3 commits into from
+174 −0

Conversation

cappellinsamuele
Copy link
Contributor

This PR introduces a new prow job enable gitops that synchronize among repositories the organization's secrets and environment variables, mainly used by github actions.
This avoids the manual settings of secrets and variables through the github interface, improving traceability and transparency.

@poiana
Copy link
Contributor

poiana commented Mar 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cappellinsamuele
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from FedeDP and jonahjon March 10, 2023 17:05
@poiana poiana added size/M and removed size/L labels Apr 21, 2023
FedeDP
FedeDP reviewed Apr 21, 2023
View reviewed changes
config/pigeon.yaml Outdated Show resolved Hide resolved
@poiana poiana added size/L and removed size/M labels Apr 24, 2023
FedeDP
FedeDP reviewed Apr 26, 2023
View reviewed changes
config/jobs/sync-ghrepos-secrets-vars/sync-ghrepos-secrets-vars.yaml
command:
- pigeon
args:
- --dry-run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!!!

@cappellinsamuele
new(prow): added job to manage org repos variables and secrets throug…
1a714ad 
…h pigeon

Signed-off-by: cappellinsamuele <[email protected]>
@cappellinsamuele
fix(config): added build and push image postsubmits jobs and presubmi…
eb97b95 
…t job. Fixed image name and added example configuration.

Signed-off-by: cappellinsamuele <[email protected]>
@cappellinsamuele
chore(images/sync-ghrepos-secrets-var/Dockerfile): removed unused env…
04bbf88 
…ironment variables.

Signed-off-by: cappellinsamuele <[email protected]>
@FedeDP
Copy link
Contributor

FedeDP commented Apr 26, 2023

@jasondellaluce @maxgio92 @LucaGuerra this LGTM! What do you think?

/hold

@poiana
Copy link
Contributor

poiana commented Jul 25, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Jul 25, 2023

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Oct 23, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Oct 23, 2023

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Jan 21, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Jan 22, 2024

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Apr 11, 2024

@cappellinsamuele: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
validate-new-drivers-centos-6-presubmit 225e790 link true /test validate-new-drivers-centos-6-presubmit
validate-new-drivers-ubuntu-aws-6-presubmit 225e790 link true /test validate-new-drivers-ubuntu-aws-6-presubmit
valdiate-new-drivers-ubuntu-generic-6-presubmit 225e790 link true /test valdiate-new-drivers-ubuntu-generic-6-presubmit
validate-new-drivers-ubuntu-gcp-6-presubmit 225e790 link true /test validate-new-drivers-ubuntu-gcp-6-presubmit
validate-new-drivers-ubuntu-azure-6-presubmit 225e790 link true /test validate-new-drivers-ubuntu-azure-6-presubmit
peribolos-syncer-pre-submit-test 04bbf88 link true /test peribolos-syncer-pre-submit-test

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@poiana
Copy link
Contributor

poiana commented Jul 10, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Jul 15, 2024

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Oct 13, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Oct 14, 2024

/remove-lifecycle stale

@maxgio92
Copy link
Member

LGTM I think @FedeDP this can be integrated. @cappellinsamuele are there other points missing from the PR as it's marked as WIP?

@cappellinsamuele
Copy link
Contributor Author

@maxgio92 There were no other points left open at the time the PR was last reviewed

@poiana
Copy link
Contributor

poiana commented Jan 15, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Jan 15, 2025

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP left review comments

@jonahjon jonahjon Awaiting requested review from jonahjon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dco-signoff: yes do-not-merge/hold do-not-merge/work-in-progress size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cappellinsamuele @poiana @FedeDP @maxgio92