-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cell Phone, Default Time Zone and State Abbreviation translation for en-PAK locale #3024
base: main
Are you sure you want to change the base?
Conversation
Here is the output that I have now in the console:
|
…r for en-PAK locale
b533dfc
to
0754377
Compare
@@ -344,11 +344,23 @@ en-PAK: | |||
- Federally Administered Tribal Areas | |||
- Azad Jammu and Kashmir | |||
- Gilgit-Baltistan | |||
state_abbr: | |||
- PK-BA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why there is a "PK" at the beginning here? I don't see that in this resource you shared.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's only 7 administrative units here with different abbreviations: https://en.wikipedia.org/wiki/Administrative_units_of_Pakistan
Where is the eight one coming from? And why are they different from the wikipedia list?
@@ -376,3 +388,17 @@ en-PAK: | |||
- "##########" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned that this mixes both landline and mobile (even though that too is wrong per Pakistan format. Should this format be updated as well to differentiate them from the cell phones?
Motivation / Background
en-PAK
locale missing cell phone format. The existingFaker::PhoneNumber.phone_number
generator mixes both landline and mobile (even though that too is wrong per Pakistan format). This PR adds cell phone format for theen-PAK
locale.It also includes state abbreviations and default time zones.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
If you're proposing a new generator or locale: