Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.76] Bump Kotlin to 1.9.25 to mitigate #49115 #49135

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

cortinico
Copy link
Contributor

Summary:

This is a change to attempt mitigating:

Changelog:

[ANDROID] [CHANGED] - Bump Kotlin to 1.9.25

Test Plan:

CI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 3, 2025
@riteshshukla04
Copy link
Contributor

Hey @cortinico , We also need to update the template for build.gradle. Right?

@riteshshukla04
Copy link
Contributor

Also can we have a fix for 0.75 stable too? I can raise a PR if needed

@cortinico
Copy link
Contributor Author

Hey @cortinico , We also need to update the template for build.gradle. Right?

Yes that's done here: react-native-community/template#102

Also can we have a fix for 0.75 stable too? I can raise a PR if needed

I'm not 100% sure that this will fix the problem for good actually, so I'd like to suggest we do 0.76 first and then do also .75 afterwards if we have a confirmation that it fixes the issue

@riteshshukla04
Copy link
Contributor

riteshshukla04 commented Feb 3, 2025

My project uses 0.75.2 . And this fixed the issue. riteshshukla04/React-native-zip-header-repro@de19abb

Please check the commit above. Also this fix has been confirmed by some users .

@cortinico
Copy link
Contributor Author

My project uses 0.75.2 . And this fixed the issue. riteshshukla04/React-native-zip-header-repro@de19abb

Please check the commit above. Also this fix has been confirmed by some users .

I've tried your project @riteshshukla04 but I can build it correctly also without your fix commit

@riteshshukla04
Copy link
Contributor

riteshshukla04 commented Feb 3, 2025

This is strange. I cant even run a new RN 0.75 cli project without this kotlin change . I honestly have no idea about this RCA. It just works :)

@riteshshukla04
Copy link
Contributor

Screenshot 2025-02-03 at 11 04 49 PM

After reverting my fix

@cortinico
Copy link
Contributor Author

That's what I'm seeing:

Untitled.mov

@riteshshukla04
Copy link
Contributor

riteshshukla04 commented Feb 3, 2025

test.mov

This is my perspective. . I am not sure what can be done in this case. @cortinico

@cortinico
Copy link
Contributor Author

@riteshshukla04 could you run ./gradlew clean --info --stacktrace and share the output here?

@riteshshukla04
Copy link
Contributor

gradle_log.txt

@cortinico PFA

@cortinico
Copy link
Contributor Author

@riteshshukla04 could you try to:

rm -rf ~/.gradle/caches/

and let me know if the issue is gone? We might just want to recommend this command as remediation.

@riteshshukla04
Copy link
Contributor

@cortinico I tired removing entire ~/.gradle the issue persist until I change RNGP or Kotlin version.

@cortinico
Copy link
Contributor Author

@cortinico I tired removing entire ~/.gradle the issue persist until I change RNGP or Kotlin version.

mmm I see. Could you share the content of the folder located in:

~/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin.jvm/org.jetbrains.kotlin.jvm.gradle.plugin/1.9.24/

specifically there should be a .pom file that contains the same as the following:

https://repo1.maven.org/maven2/org/jetbrains/kotlin/jvm/org.jetbrains.kotlin.jvm.gradle.plugin/1.9.24/org.jetbrains.kotlin.jvm.gradle.plugin-1.9.24.pom

@riteshshukla04
Copy link
Contributor

Screenshot 2025-02-04 at 8 12 03 PM

@cortinico It contains two folder one contains JAR file and one pom file

@riteshshukla04
Copy link
Contributor

But I can see that versions like 1.9.25 , 2.0.21 contains one folder with .pom file . And build works on this version. Could this be the case

@riteshshukla04
Copy link
Contributor

riteshshukla04 commented Feb 4, 2025

@cortinico I removed both the folders for 1.9.24 . It downloaded only the JAR file and not the pom file . Even tried manually replacing the jar with pom . but still it goes downloading the jar file

@cortinico
Copy link
Contributor Author

It downloaded only the JAR file and not the pom file . Even tried manually replacing the jar with pom . but still it goes downloading the jar file

Ok a couple of follow ups here:

  1. Can you share what's the content of the .jar. It's going to be a text file most likely.
  2. Are you under a proxy/vpn of any sort? Does your company has a repository mirror?

@riteshshukla04
Copy link
Contributor

Oops . I think I found the RCA . The JAR file contains an HTML saying that it is blocked by Ministry of electronics India. Thats why it is not working for me (and most of the complaints were from India).

Thank you @cortinico .
<meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0"/><style>body{margin:0px;padding:0px;}iframe{width:100%;height:100%}</style><iframe src="http://210.57.203.2:8080/webadmin/deny/dot.html" width="100%" height="100%" frameborder=0></iframe>

Screenshot 2025-02-04 at 8 35 06 PM

@cortinico
Copy link
Contributor Author

Oops . I think I found the RCA . The JAR file contains an HTML saying that it is blocked by Ministry of electronics India. Thats why it is not working for me (and most of the complaints were from India).

Thank you @cortinico . <meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0"/><style>body{margin:0px;padding:0px;}iframe{width:100%;height:100%}</style><iframe src="http://210.57.203.2:8080/webadmin/deny/dot.html" width="100%" height="100%" frameborder=0></iframe>

Screenshot 2025-02-04 at 8 35 06 PM

Yup that was my suspect. Not sure why they blocked that particular resource. I suspect they tried to tear down some website or product, and they were too 'greedy' in doing it.

Anyway I've posted an official update here: #49115 (comment)

We'll follow-up with releases for 0.76 first and 0.75 after (most likely next week)

@riteshshukla04
Copy link
Contributor

Oops . I think I found the RCA . The JAR file contains an HTML saying that it is blocked by Ministry of electronics India. Thats why it is not working for me (and most of the complaints were from India).
Thank you @cortinico . <meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0"/><style>body{margin:0px;padding:0px;}iframe{width:100%;height:100%}</style><iframe src="http://210.57.203.2:8080/webadmin/deny/dot.html" width="100%" height="100%" frameborder=0></iframe>
Screenshot 2025-02-04 at 8 35 06 PM

Yup that was my suspect. Not sure why they blocked that particular resource. I suspect they tried to tear down some website or product, and they were too 'greedy' in doing it.

Anyway I've posted an official update here: #49115 (comment)

We'll follow-up with releases for 0.76 first and 0.75 after (most likely next week)

Thanks @cortinico for helping with RCA 🚀

@cortinico cortinico merged commit f8857ba into 0.76-stable Feb 5, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants