-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.76] Bump Kotlin to 1.9.25 to mitigate #49115 #49135
Conversation
Hey @cortinico , We also need to update the template for build.gradle. Right? |
Also can we have a fix for 0.75 stable too? I can raise a PR if needed |
Yes that's done here: react-native-community/template#102
I'm not 100% sure that this will fix the problem for good actually, so I'd like to suggest we do 0.76 first and then do also .75 afterwards if we have a confirmation that it fixes the issue |
My project uses 0.75.2 . And this fixed the issue. riteshshukla04/React-native-zip-header-repro@de19abb Please check the commit above. Also this fix has been confirmed by some users . |
I've tried your project @riteshshukla04 but I can build it correctly also without your fix commit |
This is strange. I cant even run a new RN 0.75 cli project without this kotlin change . I honestly have no idea about this RCA. It just works :) |
That's what I'm seeing: Untitled.mov |
test.movThis is my perspective. . I am not sure what can be done in this case. @cortinico |
@riteshshukla04 could you run |
@riteshshukla04 could you try to:
and let me know if the issue is gone? We might just want to recommend this command as remediation. |
@cortinico I tired removing entire ~/.gradle the issue persist until I change RNGP or Kotlin version. |
mmm I see. Could you share the content of the folder located in:
specifically there should be a |
![]() @cortinico It contains two folder one contains JAR file and one pom file |
But I can see that versions like 1.9.25 , 2.0.21 contains one folder with .pom file . And build works on this version. Could this be the case |
@cortinico I removed both the folders for 1.9.24 . It downloaded only the JAR file and not the pom file . Even tried manually replacing the jar with pom . but still it goes downloading the jar file |
Ok a couple of follow ups here:
|
Oops . I think I found the RCA . The JAR file contains an HTML saying that it is blocked by Ministry of electronics India. Thats why it is not working for me (and most of the complaints were from India). Thank you @cortinico . ![]() |
Yup that was my suspect. Not sure why they blocked that particular resource. I suspect they tried to tear down some website or product, and they were too 'greedy' in doing it. Anyway I've posted an official update here: #49115 (comment) We'll follow-up with releases for 0.76 first and 0.75 after (most likely next week) |
Thanks @cortinico for helping with RCA 🚀 |
ec10666
to
a23bf0e
Compare
Summary:
This is a change to attempt mitigating:
zip END header not found
- INDIA Only #49115Changelog:
[ANDROID] [CHANGED] - Bump Kotlin to 1.9.25
Test Plan:
CI