scripts: Don't generate fboss_bins.tar.zst.tar.gz #445
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`package-fboss.py --compress` generated 2 tar files: 1. fboss_bins.tar.zst.tar.gz, which is really just a .tar.gz of all the binaries. Because it was using single-threaded compression this took 10 minutes. 2. fboss_bins.tar.zst. Generating this takes about 16 seconds. 10 minutes is way too long to wait for a build to finish, and having the same data in 2 formats isn't helpful. Remove facebook#1. There is no benefit to wasting all this time. Note that `Packaging_and_running_FBOSS.md` mentions the output of this script is called `fboss_bins.tar.gz` which wasn't true even before this change. It is true that you now need zstd support to extract the archive. Run the package script. Notice that it's much faster now, and you get less output.
|
2528b4e already made this change just before I made my PR, but I didn't notice because I hadn't updated to latest main yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package-fboss.py --compressgenerated 2 tar files:10 minutes is way too long to wait for a build to finish, and having the same data in 2 formats isn't helpful.
Step 2 was added in #251, but it left step 1 in place. Remove step 1. You do now need zstd support to extract the archive, but zstd has been around for a long time now.