Janga: config: Adjusted tmp422 sensor position to support 2nd and main source machine #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thank you for the PR @joywu-coder. We are seeing merge errors on our side. Can you please rebase onto the latest main commit? |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
joywu-coder
force-pushed
the
adjust_janga_tmp422_in_sensor_config
branch
from
a4dc071 to
0f02c51
Compare
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about tmp422 sensors in the Janga platform config file and sensor config file.
Motivation
In the current platform config file, tmp422 can only run successfully on the main source machine. The problem was that I put tmp422 on SMB_FRU_SLOT, which can only be loaded successfully on the main source.To resolve this issue, tmp422 needs to be repositioned. In this PR, I moved the tmp422 related parts to JANGA_SLOT, so that it can run successfully on both 2nd source and main source machines.
Note: This function has a limitation.The tmp422 sensors are only available in hardware from DVT2 and later. If you run the platform service and sensor service on a machine before this, an error will be reported.
Test Plan
1. In main source machine platform run successfully:
2. In main source machine sensor_service_hw_test run successfully:
3. In 2nd source machine platform run successfully:
4. In 2nd source machine sensor_service_hw_test run successfully:
janga_main_source_platform_test_log_5_14.txt
janga_main_source_sensor_test_log_5_12.txt
janga_2nd_source_platform_test_log_5_12.txt
janga_2nd_source_sensor_test_log_5_12.txt