Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upgrade command #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add upgrade command #8

wants to merge 1 commit into from

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Dec 3, 2024

This adds the command to update Express in a single step, displaying the available options based on the version specified in the package.json.

Things still to do:

  • Make the jscodeshift input more user-friendly
  • add tests

@bjohansebas bjohansebas force-pushed the update-command branch 4 times, most recently from 31a6d97 to b988b75 Compare December 12, 2024 02:18
@bjohansebas
Copy link
Member Author

@kjugi What do you think of the messages I added to the upgrade command? It no longer uses the jscodeshift output, although I think it's a bit confusing, the statistics output adds up the files in each loop.

commands/transform.ts Outdated Show resolved Hide resolved
commands/upgrade.ts Outdated Show resolved Hide resolved
commands/upgrade.ts Outdated Show resolved Hide resolved
commands/upgrade.ts Outdated Show resolved Hide resolved
@bjohansebas

This comment was marked as outdated.

@bjohansebas bjohansebas force-pushed the update-command branch 5 times, most recently from ebc5c99 to ab6321a Compare January 27, 2025 02:02
@bjohansebas bjohansebas requested a review from kjugi January 27, 2025 02:03
@bjohansebas bjohansebas marked this pull request as ready for review January 27, 2025 02:03
@bjohansebas
Copy link
Member Author

I've made some changes, @kjugi can you review them please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants