Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Try fixing ignoring files not working by namespacing paths #2893

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Feb 9, 2025

Why

fs adds a Win32 File Namespace to the beginning of the path which breaks path.relative if src does not have the namespace.

Zrzut ekranu 2025-02-9 o 12 15 45

How

Ensured that running toNamespacedPath on an already namespaced path does not add a second namespace:

> path.win32.toNamespacedPath("D:\\abc")
'\\\\?\\D:\\abc'
> path.win32.toNamespacedPath(path.win32.toNamespacedPath("D:\\abc"))
'\\\\?\\D:\\abc'

Wrapped src and srcFilePath (two arguments to path.relative) with path.toNamespacedPath so path.relative works.

Test Plan

Will release and test.

Copy link

github-actions bot commented Feb 9, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Feb 9, 2025
@sjchmiela sjchmiela force-pushed the stanley/windows-to-namespaced-path branch from b063d0e to 83ba3f1 Compare February 9, 2025 11:17
Copy link

github-actions bot commented Feb 9, 2025

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela requested a review from szdziedzic February 9, 2025 11:18
@sjchmiela sjchmiela merged commit 1bf6757 into main Feb 9, 2025
6 checks passed
@sjchmiela sjchmiela deleted the stanley/windows-to-namespaced-path branch February 9, 2025 11:18
Copy link

github-actions bot commented Feb 9, 2025

Size Change: -1.09 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -1.09 kB (0%)

compressed-size-action

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.64%. Comparing base (0e7a8bf) to head (83ba3f1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/vcs/local.ts 71.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
+ Coverage   52.64%   52.64%   +0.01%     
==========================================
  Files         588      588              
  Lines       23187    23191       +4     
  Branches     4856     4857       +1     
==========================================
+ Hits        12204    12207       +3     
- Misses      10017    10018       +1     
  Partials      966      966              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant