Make sure quotes in json are escaped

[iainbeeston]

Why

I'm seeing issues when I run eas build:list --json because git commit messages are included in the result but git commit messages sometimes contain quotes. These aren't escaped and so I am seeing invalid json in the output that looks like this:

{
\\...
"gitCommitMessage": "Changed some "stuff""
}

How

I've changed this so that string values (only) are escaped using JSON.stringify.

Test Plan

I'd love to include tests for this but I couldn't see an appropriate test file to add them to. Considering that I would test this like this:

1. Create a build for a commit that contains a commit message with double quotes in it
2. Run eas build:list --json --non-interactive and confirm that the gitCommitMessage is there but has the double quotes escaped
3. Try parsing the json using jq '.[]' to confirm that it's valid json (the json should be output by jq and there should be no parsing error

[github-actions]

Subscribed to pull request

File Patterns	Mentions
**/*	@szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

[szdziedzic]

Hi,

I believe the output from sanitizeValue is already passed to JSON.stringify:

eas-cli/packages/eas-cli/src/utils/json.ts

Line 19 in 365a746

Log.log(JSON.stringify(sanitizeValue(value), null, 2));

I run eas build:list --json --non-interactive and I checked it worked for me just fine:

Can you share more details about how you were able to see this issue?

[iainbeeston]

Thanks @szdziedzic - you're right. I'm calling eas:build list in a script and it looks like something else must be messing with the json. I'm closing this as I don't think there is an issue.