Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] change url in fingerprint:compare #2861

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 4, 2025

Why

I'm in the process of changing the fingerprint path to fingerprints in the website to be consistent with all our other routes here https://github.com/expo/universe/pull/18533

This PR updates the URL to match the desired endpoint path on the Expo website.

How

Updated the URL path construction in the FingerprintCompare command to use the correct plural form /fingerprints/ instead of /fingerprint/ when generating the comparison URL.

Test Plan

Ran fingerprint:compare

Copy link
Member Author

quinlanj commented Feb 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Feb 4, 2025

Size Change: +688 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +688 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.39%. Comparing base (7f46bae) to head (49f787e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2861   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files         589      589           
  Lines       23118    23118           
  Branches     4839     4839           
=======================================
  Hits        12111    12111           
  Misses      10040    10040           
  Partials      967      967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 4, 2025

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj marked this pull request as ready for review February 4, 2025 00:15
Copy link

github-actions bot commented Feb 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants