Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] Machine-converted EOF validation tests #1169

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 3, 2025

πŸ—’οΈ Description

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz
Copy link
Member

marioevz commented Feb 5, 2025

My only comment about all of these tests is that, the more Container(raw_bytes="... tests we have, the more manual refactoring we will have to do if some of the nice-to-have (e.g. data section type 0x04 -> 0xff) changes are approved for Osaka.

So I think we could limit adding these to only adding the ones that are really bumping the coverage IMO.

@chfast
Copy link
Member Author

chfast commented Feb 5, 2025

I never wanted to merge this. This is my work in progress conversion TODO list.

@chfast chfast force-pushed the eof/convert_script branch 4 times, most recently from af053e6 to 7bada3a Compare February 6, 2025 11:02
@chfast chfast changed the title Machine-converted EOF validation tests [DON'T MERGE] Machine-converted EOF validation tests Feb 6, 2025
@chfast chfast force-pushed the eof/convert_script branch from 7bada3a to 52add6a Compare February 8, 2025 16:11
@chfast chfast force-pushed the eof/convert_script branch from 52add6a to 7340b41 Compare February 8, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants