-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/adapt eip6780 selfdestruct revert & reentrancy_selfdestruct to execute mode #1167
feat/adapt eip6780 selfdestruct revert & reentrancy_selfdestruct to execute mode #1167
Conversation
cc @marioevz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for doing this.
A few minor comments.
tests/cancun/eip6780_selfdestruct/test_reentrancy_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
tests/cancun/eip6780_selfdestruct/test_reentrancy_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
tests/cancun/eip6780_selfdestruct/test_reentrancy_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
tests/cancun/eip6780_selfdestruct/test_reentrancy_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
@marioevz Fixed your reviews, and rerun testing locally. Thanks for your feedbacks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job, thanks for these changes!
We reduced gas limit from 100.000.000 to 20.000.000 for avoiding maxblockgaslimit for some chains.