Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/adapt eip6780 selfdestruct revert & reentrancy_selfdestruct to execute mode #1167

Conversation

huyngopt1994
Copy link
Contributor

plugins: html-4.1.1, json-report-1.5.0, metadata-3.1.1, custom-report-1.0.1, xdist-3.6.1, typeguard-4.3.0
collected 6 items / 1 deselected / 5 selected                                                                                                                                                                  

tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_created_in_same_tx_with_revert[fork_Cancun-transaction_post-no_outer_selfdestruct-same_tx] Starting EOA index: 0x7e86ab011d54ff42e0187e246ce6a5900063147355b14f27feae79f32f533eef
Deploying contract with gas limit: 135602
Deploying contract with gas limit: 162902
PASSEDUsed balance=0.000429135000000003

tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_created_in_same_tx_with_revert[fork_Cancun-transaction_post-outer_selfdestruct_before_inner_call-same_tx] Deploying contract with gas limit: 135626
Deploying contract with gas limit: 178028
PASSEDUsed balance=0.000448805000000003

tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_created_in_same_tx_with_revert[fork_Cancun-transaction_post-outer_selfdestruct_after_inner_call-same_tx] Deploying contract with gas limit: 135626
Deploying contract with gas limit: 177596
PASSEDUsed balance=0.000498087000000003

tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_not_created_in_same_tx_with_revert[fork_Cancun-transaction_post-no_outer_selfdestruct-not_same_tx-init_balance_2] Deploying contract with gas limit: 130922
Deploying contract with gas limit: 162902
PASSEDUsed balance=0.000360561000000002

tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_not_created_in_same_tx_with_revert[fork_Cancun-transaction_post-outer_selfdestruct_before_inner_call-not_same_tx-init_balance_2] Deploying contract with gas limit: 130922
Deploying contract with gas limit: 178028
PASSEDUsed balance=0.000374958000000002

tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_not_created_in_same_tx_with_revert[fork_Cancun-transaction_post-outer_selfdestruct_after_inner_call-not_same_tx-init_balance_2] Deploying contract with gas limit: 130922
Deploying contract with gas limit: 177596
PASSEDUsed balance=0.000429501000000002


=============================================================================================== warnings summary ===============================================================================================
tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_created_in_same_tx_with_revert[fork_Cancun-transaction_post-no_outer_selfdestruct-same_tx]
tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_created_in_same_tx_with_revert[fork_Cancun-transaction_post-outer_selfdestruct_before_inner_call-same_tx]
tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_created_in_same_tx_with_revert[fork_Cancun-transaction_post-outer_selfdestruct_after_inner_call-same_tx]
tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_not_created_in_same_tx_with_revert[fork_Cancun-transaction_post-no_outer_selfdestruct-not_same_tx-init_balance_2]
tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_not_created_in_same_tx_with_revert[fork_Cancun-transaction_post-outer_selfdestruct_before_inner_call-not_same_tx-init_balance_2]
tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py::test_selfdestruct_not_created_in_same_tx_with_revert[fork_Cancun-transaction_post-outer_selfdestruct_after_inner_call-not_same_tx-init_balance_2]
  /opt/homebrew/Cellar/[email protected]/3.13.1/Frameworks/Python.framework/Versions/3.13/lib/python3.13/copy.py:152: DeprecationWarning: Pickle, copy, and deepcopy support will be removed from itertools in Python 3.14.
    rv = reductor(4)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================================================================== 6 passed, 1 deselected, 6 warnings in 273.06s (0:04:33) ============================================================================

We reduced gas limit from 100.000.000 to 20.000.000 for avoiding maxblockgaslimit for some chains.

@huyngopt1994
Copy link
Contributor Author

cc @marioevz

@huyngopt1994 huyngopt1994 changed the title feat/adapt eip6780 selfdestruct revert to execute mode feat/adapt eip6780 selfdestruct revert & reentrancy_selfdestruct to execute mode Feb 4, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this.

A few minor comments.

@huyngopt1994
Copy link
Contributor Author

@marioevz Fixed your reviews, and rerun testing locally. Thanks for your feedbacks.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, thanks for these changes!

@marioevz marioevz merged commit 03ca2a4 into ethereum:main Feb 6, 2025
12 checks passed
@huyngopt1994 huyngopt1994 deleted the feat/adapt-eip6780-selfdestruct-revert-to-execute-mode branch February 6, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants