Add a Multi-Project Search Rest Test #128657
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Rest IT specifically for search in MultiProject. Everything was already working as expected, but we were a bit light on explicit testing for search, which as _the_ core capability of Elasticsearch is worth testing thoroughly and clearly.
tvernum
added
>test
|
Pinging @elastic/es-search (Team:Search) |
benchaplin
approved these changes
May 30, 2025
| "query": { "term": { "project": 1 } } | ||
| } | ||
| """; | ||
| results1 = getHitIds(search(projectId1, indexPrefix + "-*", query)); |
There was a problem hiding this comment.
Nit: maybe we should move getHitIds into search(ProjectId projectId, String indexExpression, String body) so we don't need to call it here?
| results2 = search(projectId2, indexName); | ||
| assertThat(results2, containsInAnyOrder(docId2a, docId2b)); | ||
|
|
||
| results1 = search(projectId1, indexPrefix + "-*"); |
There was a problem hiding this comment.
Just curious - what's being tested with this final search?
| // That is, an aggregation with size:0 | ||
| ObjectPath response = search(projectId1, indexName, query); | ||
| String context = "In search response: " + response; | ||
| assertThat(response.evaluateArraySize("aggregations.proj.buckets"), equalTo(1)); |
There was a problem hiding this comment.
Did you mean to add context to these assertions :)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Rest IT specifically for search in MultiProject. Everything was already working as expected, but we were a bit light on explicit testing for search, which as the core capability of Elasticsearch is worth testing thoroughly and clearly.
Relates: ES-9352