Skip to content

responsive reader modal height and up annotations background color #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

responsive reader modal height and up annotations background color #3052

wants to merge 5 commits into from

Conversation

arthur-lemeur
Copy link
Collaborator

@arthur-lemeur arthur-lemeur commented Jun 30, 2025 •
edited
Loading

Fixes #3017
Fixes #3006

@arthur-lemeur arthur-lemeur requested a review from panaC June 30, 2025 16:07
@arthur-lemeur arthur-lemeur changed the title repsonsive reader modal height and up annotations background color responsive reader modal height and up annotations background color Jun 30, 2025
@arthur-lemeur arthur-lemeur marked this pull request as ready for review July 1, 2025 08:48
panaC
panaC reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@panaC panaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Bookmarks and annotation does not profit of this slack gain.

@danielweck
Copy link
Member

ah yes, pagination with a fixed number of items (rows in the list) is problematic ... and we can only have an approximation of row height because it depends on content?

@danielweck
Copy link
Member

Screenshot 2025-07-14 at 11 52 28

@danielweck
Copy link
Member

Hello @arthur-lemeur see above screenshot, there is a bug with the Aa dialog

@danielweck
Copy link
Member

Screenshot 2025-07-14 at 11 55 09

@danielweck
Copy link
Member

...and now, after merging develop into this PR branch, the dialog height is back to short instead of stretching ... I am very confused!! :)

@danielweck
Copy link
Member

So I have done more regression testing since 3d0a96d (your last PR commit), but there's something in the develop branch that breaks the logic of this PR (CSS side effect?) ... yet the diff shows nothing relevant, as far as I can tell ... I am very confused. Could you please checkout the latest develop-sync'ed revision of fix/css-update at your end to verify that you are also able to reproduce the non-working CSS logic?

@arthur-lemeur
Copy link
Collaborator Author

Problem solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panaC panaC panaC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CSS] on big screen modal dialog should be bigger [CSS] regression bookmark/annotations background not grayed anymore
3 participants
@arthur-lemeur @danielweck @panaC