Add Provider : Leonardo #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DninoAdnane
requested changes
Dec 3, 2024
| "prompt": text, | ||
| "width": int(size[0]), | ||
| "height": int(size[1]), | ||
| "modelId": get_model_id_image.get(model, model), |
There was a problem hiding this comment.
I just didn't really understand this ? :
get_model_id_image.get(model, model)you want to keep the model as a name is case of the model not in the dictionary ?
| url = f"{self.base_url}/generations" | ||
|
|
||
| response_dict = LeonardoApi.__get_response(self, url, payload) | ||
| image_url = [image.get('url') for image in response_dict.get('generations_by_pk', {}).get('generated_images', [])] |
There was a problem hiding this comment.
I would have used the function I showed once, that retrieve data inside a dictionary while handling the None or Key not found errors
| "width": int(size[0]), | ||
| "height": int(size[1]), | ||
| "modelId": get_model_id_image.get(model, model), | ||
| "num_images": num_images, |
There was a problem hiding this comment.
I'm not sure if this comment is relevant, as we should already limit in the back the number of images that a user can retrieve, but I think it would be good if we limit here also in case of
| url = f"{self.base_url}/generations" | ||
|
|
||
| response_dict = LeonardoApi.__get_response(self, url, payload) | ||
| image_url = [image.get('url') for image in response_dict.get('generations_by_pk', {}).get('generated_images', [])] |
| self, url: str, payload: dict | ||
| ) -> Union[Generator, dict]: | ||
| # Launch job | ||
| launch_job_response = requests.post(url, headers=self.headers, json=payload) |
There was a problem hiding this comment.
We can here also add a try catch like for the previous one, to catch unexpected errors like timeout errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.