Skip to content

EAISCRUM-1524-design-llm-for-image-feature-explicit-content-and-logo-detection #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Daggx
Copy link
Contributor

@Daggx Daggx commented Jun 13, 2024

No description provided.

@Daggx Daggx requested a review from KyrianC June 13, 2024 14:37
@KyrianC
Copy link
Collaborator

KyrianC commented Jun 13, 2024

I think it would be cool to use Langchain for this, with structred_outputs as we already have all the pydantic models ready, we would just add description to each fields.

only problem is maybe there would be dependency conflicts between pydantic v1 & v2.
What do you think?

@Daggx
Copy link
Contributor Author

Daggx commented Jun 13, 2024

I think it would be cool to use Langchain for this, with structred_outputs as we already have all the pydantic models ready, we would just add description to each fields.

only problem is maybe there would be dependency conflicts between pydantic v1 & v2. What do you think?

That's what i was going to use for the document parsing part since the financial/invoice/receipt dataclass are pretty huge, here since they are pretty simple l(ogo & explicit content) i didn't think it would add anything, but we could do it for them also.

@Daggx Daggx marked this pull request as draft June 14, 2024 10:13
@KyrianC
Copy link
Collaborator

KyrianC commented Jun 14, 2024

I think it would be cool to use Langchain for this, with structred_outputs as we already have all the pydantic models ready, we would just add description to each fields.
only problem is maybe there would be dependency conflicts between pydantic v1 & v2. What do you think?

That's what i was going to use for the document parsing part since the financial/invoice/receipt dataclass are pretty huge, here since they are pretty simple l(ogo & explicit content) i didn't think it would add anything, but we could do it for them also.

Okay! we can let it like that, and if ever there is errors, like the model not returning the right output, we can try with langchain if it performs better

@Daggx Daggx closed this Jun 20, 2024
@Daggx Daggx deleted the EAISCRUM-1524-design-llm-for-image-feature-explicit-content-and-logo-detection branch June 20, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants