-
Notifications
You must be signed in to change notification settings - Fork 11
Memory usage performance test [15785] #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
834dde5
to
50bc82c
Compare
50bc82c
to
63ba45b
Compare
e0c97c0
to
8734ae2
Compare
8734ae2
to
a39e4e4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 58.42% 58.42%
=======================================
Files 33 33
Lines 4421 4421
Branches 2352 2352
=======================================
Hits 2583 2583
Misses 54 54
Partials 1784 1784 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a39e4e4
to
1fda1ac
Compare
@EduPonz I think I don't have enough knowledge about bash scripting to review this one ... |
@jparisu Please rebase this one |
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
1fda1ac
to
34c4112
Compare
I have rebased the PR while looking at it. I think we ought to have a discussion about this; right now, it's a draft as it is far from being ready to be incorporated in CI and merged. The pain points I see with the current for merging as a test are:
Another possibility would be to add the script as a resource from which users can benefit, but I'm really attracted to the idea of having this kind of stress tests. |
This test was never meant to be added in the CI. This was intended to be a manual test to have a partial idea of what is the memory usage of an execution. PD: I personally think we have bigger problems that having a stress test. |
Signed-off-by: jparisu <[email protected]>
I completely agree. I'd leave this as a draft for now and we'll see in the future |
@jparisu which is the status of this Draft? Does it make sense to try to merge it? I think we should change the status and assign a milestone so the discussion is had at some point. |
Merge after: