Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/update-webauthn-v2.4.0 #149

Merged
merged 4 commits into from
Dec 5, 2024
Merged

fix/update-webauthn-v2.4.0 #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e49f61
Update to webauthn==2.4.0
MasterKale Dec 5, 2024
74e203a
Use hints support in webauthn
MasterKale Dec 5, 2024
108b658
Update to latest @simplewebauthn/browser
MasterKale Dec 5, 2024
c388eb4
Add registration service tests
MasterKale Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Pipfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions _app/homepage/services/registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
AuthenticatorSelectionCriteria,
AuthenticatorAttachment,
PublicKeyCredentialDescriptor,
PublicKeyCredentialHint,
ResidentKeyRequirement,
)
from webauthn.helpers.cose import COSEAlgorithmIdentifier
Expand Down Expand Up @@ -110,6 +111,8 @@ def generate_registration_options(
if "rs256" in algorithms:
supported_pub_key_algs.append(COSEAlgorithmIdentifier.RSASSA_PKCS1_v1_5_SHA_256)

_hints = [PublicKeyCredentialHint(hint) for hint in hints]

registration_options = generate_registration_options(
rp_id=settings.RP_ID,
rp_name=settings.RP_NAME,
Expand All @@ -125,6 +128,7 @@ def generate_registration_options(
)
for cred in existing_credentials
],
hints=_hints,
)

# py_webauthn will default to all supported algorithms on an empty `algorithms` list
Expand Down
2 changes: 2 additions & 0 deletions _app/homepage/static/js/simplewebauthn-browser.12.0.0.umd.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading