Add Windows Server 2025 variant #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Jan 22, 2025
| @@ -166,6 +166,7 @@ for version in "${versions[@]}"; do | |||
| | "alpine" + . else empty end, | |||
| if $doc.jdk.arches | keys | any(startswith("windows-")) then | |||
| ( | |||
| "ltsc2025", | |||
There was a problem hiding this comment.
It's interesting and mostly orthogonal that we didn't add any Nano Server past 1809 here -- something worth digging into later, maybe.
There was a problem hiding this comment.
Maybe it's something like docker-library/mongo#720 (comment) 😬 🙈
There was a problem hiding this comment.
After we merge this, maybe we can try adding them back again so we can add useful comments.
tianon
approved these changes
Jan 22, 2025
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 22, 2025
Changes: - docker-library/openjdk@bf64d21: Merge pull request docker-library/openjdk#544 from infosiftr/ltsc2025 - docker-library/openjdk@865aad9: Add Windows Server 2025 variant
This was referenced Jan 22, 2025
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 22, 2025
Changes: - docker-library/openjdk@cd21f0d: Merge pull request docker-library/openjdk#545 from infosiftr/moar-nanoserver - docker-library/openjdk@534646f: Add more Nano Server variants - docker-library/openjdk@bf64d21: Merge pull request docker-library/openjdk#544 from infosiftr/ltsc2025 - docker-library/openjdk@865aad9: Add Windows Server 2025 variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Windows Server ltsc2025; keep 1809 as it is still in extended support (we may drop it later, even while it is supported by Windows).
Refs: docker-library/official-images#18143