Allow setting annotations for deployments #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change basically forwards `raster-eoapi.annotations` to the annotations of the respective deployment. There are no official guidelines on key structuring, but this follows conventions set by other large charts like [1] where properties on the top level object are forwarded to the central kubernetes object, in this case the deployment. Other objects could still be customized with sub-keys, e.g. `raster-eoapi.service.annotations` could be applied to the respective kubernetes service. The values currently also contain a `settings` key. Since properties like `image` or `command` are configured directly in `raster-eoapi`, I've also placed the annotations directly here. However they could also be moved to `settings`. [1] https://artifacthub.io/packages/helm/grafana/grafana
totycro
force-pushed
the
deployment-annotations
branch
from
01c8e77 to
c582215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change basically forwards
raster-eoapi.annotationsto the annotations of the respective deployment. There are no official guidelines on key structuring, but this follows conventions set by other large charts where properties on the top level object are forwarded to the central kubernetes object, in this case the deployment.Other objects could still be customized with sub-keys, e.g.
raster-eoapi.service.annotationscould be applied to the respective kubernetes service.The values currently also contain a
settingskey. Since properties likeimageorcommandare configured directly inraster-eoapi, I've also placed the annotations directly here. However they could also be moved tosettings.Related discussion: #172