Skip to content

fix(app): 修复 picker 组件默认插槽不生效的bug #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

chouchouji
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented May 15, 2025

Size report

Path Size
packages/size-check/dist/size-check.es.js 47.18 KB (0%)
packages/size-check/dist/style.css 2.82 KB (0%)
packages/uni-app/dist/uni-app.es.js 2.47 KB (0%)
packages/uni-h5-vue/dist/vue.runtime.esm.js 76.41 KB (0%)
packages/uni-mp-vue/dist/vue.runtime.esm.js 43.13 KB (0%)
packages/uni-mp-alipay/dist/uni.api.esm.js 14.69 KB (0%)
packages/uni-mp-alipay/dist/uni.mp.esm.js 7.99 KB (0%)
packages/uni-mp-baidu/dist/uni.api.esm.js 11.34 KB (0%)
packages/uni-mp-baidu/dist/uni.mp.esm.js 9.68 KB (0%)
packages/uni-mp-qq/dist/uni.api.esm.js 10.65 KB (0%)
packages/uni-mp-qq/dist/uni.mp.esm.js 7.6 KB (0%)
packages/uni-mp-toutiao/dist/uni.api.esm.js 10.53 KB (0%)
packages/uni-mp-toutiao/dist/uni.mp.esm.js 9.42 KB (0%)
packages/uni-mp-weixin/dist/uni.api.esm.js 11.66 KB (0%)
packages/uni-mp-weixin/dist/uni.mp.esm.js 7.94 KB (0%)
packages/uni-quickapp-webview/dist/uni.api.esm.js 10.6 KB (0%)
packages/uni-quickapp-webview/dist/uni.mp.esm.js 8.16 KB (0%)

@chouchouji chouchouji requested a review from zhenyuWang May 20, 2025 08:30
@zhenyuWang zhenyuWang requested a review from Copilot May 20, 2025 10:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unused element from the picker component to simplify the markup and reduce unnecessary DOM elements.

  • Removed the unused tag within the uni-picker component.
Comments suppressed due to low confidence (1)

packages/uni-app-plus/src/view/components/picker/index.tsx:355

  • The removal of the element simplifies the component's markup. Please ensure that this change does not adversely affect consumers expecting to inject custom content via this slot.
<slot />

@chouchouji chouchouji requested a review from StrivingRabbit May 20, 2025 10:50
@zhenyuWang zhenyuWang removed their request for review May 20, 2025 11:28
@chouchouji chouchouji changed the title fix(app): picker 组件移除无用的 slot 标签 fix(app): 修复 picker 组件默认插槽不生效的bug May 21, 2025
@StrivingRabbit StrivingRabbit merged commit 8a23383 into next May 21, 2025
4 checks passed
@chouchouji chouchouji deleted the fix-picker branch May 21, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants