Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow config http protocol to be passed to clickhouse driver. #9195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BrandonFreeman-Cavallo
Copy link

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

We use clickhouse and tried to upgrade cube past v1.1.6. It appears that the internal driver has changed, and a problem was introduced where the config for protocol was coalescing to https regardless of passed parameter. It needed some parenthesis to be accurate.

Broke:

const config = {};
config.protocol = 'http';

const protocol =
  config.protocol ?? getEnv('dbSsl', { dataSource }) ? 'https:' : 'http:';

console.log(protocol);

// out 'https:'

Fixed:

const config = {};
config.protocol = 'http';

const protocol =
  config.protocol ?? (getEnv('dbSsl', { dataSource }) ? 'https:' : 'http:');

console.log(protocol);

// out 'http:'

@BrandonFreeman-Cavallo BrandonFreeman-Cavallo requested a review from a team as a code owner February 6, 2025 15:55
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant