Skip to content

Upgrade normalize.css to v7.0.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Upgrade normalize.css to v7.0.0 #17

wants to merge 1 commit into from

Conversation

maiis
Copy link

@maiis maiis commented May 26, 2017

No description provided.

@jonathantneal
Copy link
Collaborator

Thanks for filing this PR! I dislike turning a PR down, but you may have noticed your tests are failing. Please see: https://github.com/jonathantneal/postcss-normalize/blob/master/CONTRIBUTING.md#submitting-pull-requests

There’s another issue here, too. PostCSS Normalize is predicated on using a browserlist to normalize the differences between the browsers one supports. I’ll make this clear in the README.md.

I say that because several opinionated styles were regrettably added to the earliest versions of normalize.css. They were removed in v6, but have since been re-introduced in v7. In fact, that’s the only difference between v6 and v7. As a co-creator of normalize.css, I’m saying those changes are wrong, and that release was cut immaturely. In all the years normalize.css has been around, its opinionated additions have never been adopted by or provided as direction by any browser or standards body. They’re not going to happen. Therefore, adding them here when a browserlist is involved would be pure fantasy, akin to babel lonesomely changing what typeof returns in JS. :)

There’s plenty good in normalize.css :) and we’ll accept any additions that actually help browsers, or as I’ve heard:

Eat the meat and spit out the bones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants