Skip to content

feat(template) add rybbit analytics #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

nktnet1
Copy link
Contributor

@nktnet1 nktnet1 commented May 16, 2025

Changes

Similar to #5808 (chibisafe template), the Caddy reverse proxy container can potentially be replaced with Coolify magic (need a bit of help on this).

Important note is that, as mentioned in rybbit-io/rybbit#135, we need to strip the /api path while rewriting, e.g.

Works ✅:

http://frontend:3002/api/test/example    =>    http://backend:3001/test/example

Won't work ❌:

http://frontend:3002/api/test/example    =>    http://backend:3001/api/test/example

If we want Rybbit to work internally.

@nktnet1 nktnet1 changed the base branch from v4.x to next May 16, 2025 09:46
@nktnet1 nktnet1 changed the title Rybbit template feat(template) add rybbit analytics May 16, 2025
@nktnet1 nktnet1 marked this pull request as ready for review May 20, 2025 08:09
@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label May 23, 2025
Copy link

gitguardian bot commented May 27, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
17327534 Triggered Laravel Encryption Key 060d15f tests/Feature/ConvertContainerEnvsToArray.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Lqm1
Copy link

Lqm1 commented May 31, 2025

https://www.rybbit.io/docs/v1-migration

I expect Rybbit support.
v1.0 has been released and a rewrite issue may have been resolved.

@nktnet1
Copy link
Contributor Author

nktnet1 commented May 31, 2025

Yep, I'll update the PR for the 1.0.0 release.

Edit: running into some issues in the Dokploy template, so I'll try to get that sorted before attempting Coolify.

@nktnet1 nktnet1 marked this pull request as draft May 31, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Service Issues requesting or PRs adding/fixing service templates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants