-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: Custom Traefik entrypoint support #5694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arnokristiaan
wants to merge
7
commits into
coollabsio:next
Choose a base branch
from
arnokristiaan:next
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version to 4.0.0-beta.414 in configuration files
…IPs in terminal server
- Added custom entrypoint support for Traefik - Refactored some duplicate code
@andrasbacsai Would it be possible to receive any comment on why this PR is closed? |
It was a mistake, sorry. I recreated the |
@andrasbacsai That explains it, thanks for the response! |
How will this implementation work? How can I make use of it? |
@Windol I've edited the description of this PR with a usage chapter to explain how to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a case in which we want to define a custom Traefik entrypoint in the proxy labels, for security purposes, but we cannot really use the entrypoint in the applications. This is caused because variables cannot be used in labels in order to specify a host. This PR mitigates that problem by using the Coolify domain settings for an application.
Usage
In the settings of an application under General > Domains you can set a domain like https://your.own.domain:8888 which will tell the proxy to route traffic to https://your.own.domain to the container on internal port 8888.
To use the custom entrypoint, which you created through your custom proxy labels, you change the domain to https://[email protected]:8888. This will do the same but will use the "your-custom-entrypoint" as entrypoint instead of the default https or http entrypoints.
Multiple entrypoints are supported by comma-separation.
Changes