Skip to content

tweak(backup): switch S3 storage class to STANDARD_IA #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

tabarra
Copy link

@tabarra tabarra commented Apr 22, 2025

This adds the flag that specifies that the S3 object should use the "Standard - Infrequent Access" class, which is 45% cheaper than the standard one.

Caution

I know that doing a s3:PutObject with a new storage class works and does not break compatibility, but I have not compiled and tested this PR.

Changes

Issues

This adds the flag that specifies that the S3 object should use the "Standard - Infrequent Access" class, which is 45% cheaper than the standard one.  
Ref: coollabsio#5670
@andrasbacsai andrasbacsai deleted the branch coollabsio:next May 9, 2025 06:31
@andrasbacsai
Copy link
Member

It was a mistake, sorry. I recreated the next branch and it auto-closed this PR.

@andrasbacsai andrasbacsai reopened this May 9, 2025
@andrasbacsai
Copy link
Member

This is a good addition, but unfortunately, we cannot hardcode it as it fails if the storage class is not available. So I will add a small input box where you can set the storage class manually.

  1. If it's empty, no --storage-class is used in the mc command
  2. If not, add the right option.

This needs:

  • A db migration (add a storage_class to ScheduledDatabaseBackup model).
  • UI changes in backup-edit.blade.php.
  • Based on the input, define the right mc command.

Can you please do these instead of the hardcoded command?

@andrasbacsai andrasbacsai added 💤 Waiting for feedback Issues awaiting a response from the author. 💤 Waiting for changes PRs awaiting changes from the author. labels May 13, 2025
@peaklabs-dev peaklabs-dev removed the 💤 Waiting for feedback Issues awaiting a response from the author. label May 13, 2025
@peaklabs-dev
Copy link
Member

Thank you for your contribution. Due to inactivity, we're closing this PR. If you'd like to revisit this change, feel free to reopen this PR or open a new pull request.

@github-actions github-actions bot removed the 💤 Waiting for changes PRs awaiting changes from the author. label May 27, 2025
@tabarra
Copy link
Author

tabarra commented May 27, 2025

@peaklabs-dev I mean, this is still important... I just didn't have the time to set up the dev env to apply the required changes and test it out.

@peaklabs-dev peaklabs-dev reopened this May 27, 2025
@peaklabs-dev peaklabs-dev added the 💤 Waiting for changes PRs awaiting changes from the author. label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤 Waiting for changes PRs awaiting changes from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants