[OPIK-901] [Activation rate] Add line highlights in activation rate code blocks #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadereiko
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Nice implementation! I like the idea of commenting with #... to identify highlighted lines.
- Although, playing with it, I noticed that a user can't select text in highlighted lines.
- This one is up to you: it might make sense to highlight lines without sending lines. just to check by the plugin if there is
# HIGLIGHT...and add the highlight
| `os.environ["OPIK_API_KEY"] = "${masked ? maskAPIKey(apiKey) : apiKey}"`; | ||
| export const buildWorkspaceNameConfig = (workspaceName: string) => | ||
| `os.environ["OPIK_WORKSPACE"] = "${workspaceName}"`; | ||
| // TODO lala workspace name |
andriidudar
force-pushed
the
andriidudar/OPIK-901-line-highlights
branch
from
664a1dc to
b4461e1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
Resolves #
Testing
Documentation