Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPIK-863] Allow to quickly select multiple rows with Shift+Click #1200

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[OPIK-863] Allow to quickly select multiple rows with Shift+Click #1200

merged 2 commits into from
Feb 4, 2025

Conversation

andriidudar
Copy link
Contributor

Details

image

Issues

Resolves #

Testing

  • Manually tested on the Projects page (with sorting applied)
  • Manually tested on the Experiments page with groups and subgroup rows

Documentation

@andriidudar andriidudar requested a review from a team as a code owner February 3, 2025 13:11
aadereiko
aadereiko approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@aadereiko aadereiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

apps/opik-frontend/src/components/shared/DataTable/utils.tsx
? previousClickedRowID
: "",
);
const isLastSelected = !rowsMap[context.row.id]?.getIsSelected() || false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as !rowsMap[context.row.id]?.getIsSelected();

@andriidudar andriidudar merged commit 4b5e746 into main Feb 4, 2025
2 checks passed
@andriidudar andriidudar deleted the andriidudar/OPIK-863-table-multy-row-select branch February 4, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aadereiko aadereiko aadereiko approved these changes

Assignees

@ferc ferc

@aadereiko aadereiko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriidudar @aadereiko @ferc