-
Notifications
You must be signed in to change notification settings - Fork 3
rearrange submodule checkouts and add CI workflows #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c33bd9
to
18f0e87
Compare
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
f2c93e9
to
a8585ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a bunch of comments, but no real blocker
paths: | ||
- 'apps/codecov-api/**' | ||
- 'apps/codecov-api' | ||
- 'libs/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on being explicit about the specific lib (i.e. libs/shared/
)? It will prevent triggering on libraries that we won't import in API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably a good idea. for the moment, i did it this way because i wasn't sure a change inside a submodule would register to GHA. these rules match the submodule placeholder itself so if you check out a different revision it should kick off CI
a8585ae
to
5032de6
Compare
5032de6
to
c648b64
Compare
|
c648b64
to
3df2dcd
Compare
i overrode the branch protection rule. unclear why i had to. it says i am not authorized to push to |
see also: