Skip to content

rearrange submodule checkouts and add CI workflows #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

@matt-codecov matt-codecov force-pushed the matt/rearrange-add-ci branch 9 times, most recently from 8c33bd9 to 18f0e87 Compare February 13, 2025 20:37
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a bunch of comments, but no real blocker

paths:
- 'apps/codecov-api/**'
- 'apps/codecov-api'
- 'libs/**'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on being explicit about the specific lib (i.e. libs/shared/)? It will prevent triggering on libraries that we won't import in API.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a good idea. for the moment, i did it this way because i wasn't sure a change inside a submodule would register to GHA. these rules match the submodule placeholder itself so if you check out a different revision it should kick off CI

@matt-codecov
Copy link
Collaborator Author

@matt-codecov matt-codecov added this pull request to the merge queue Feb 20, 2025
@matt-codecov matt-codecov removed this pull request from the merge queue due to a manual request Feb 20, 2025
@matt-codecov matt-codecov added this pull request to the merge queue Feb 20, 2025
@matt-codecov matt-codecov removed this pull request from the merge queue due to a manual request Feb 20, 2025
@matt-codecov matt-codecov added this pull request to the merge queue Feb 20, 2025
@matt-codecov matt-codecov removed this pull request from the merge queue due to a manual request Feb 20, 2025
@matt-codecov matt-codecov added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 20, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@matt-codecov matt-codecov merged commit 0b95361 into main Feb 20, 2025
45 of 47 checks passed
@matt-codecov matt-codecov deleted the matt/rearrange-add-ci branch February 20, 2025 21:36
@matt-codecov
Copy link
Collaborator Author

i overrode the branch protection rule. unclear why i had to. it says i am not authorized to push to main but all the required checks passed. i will look into it for a future PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants