Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external python to be used in make #21581

Merged

Conversation

chriswiggins
Copy link
Contributor

In build environments where a different python is required to the one on the host (in our case, yocto), the makefile needs to support an external python3 location.

We were running into issues where our build host used python 3.11, but the yocto version was 3.10, so the files were going into the wrong dist-packages folder.

In our case, adding the following line to our yocto recipe for cockpit (with this fix) now works as required:

EXTRA_OEMAKE += "PYTHON3=${STAGING_BINDIR_NATIVE}/python3-native/python3"

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's reasonable, thanks! I'll adjust the commit message to prefix "build:" on merging.

Triggered the tests.

@martinpitt martinpitt merged commit 3525d23 into cockpit-project:main Feb 4, 2025
86 checks passed
@chriswiggins chriswiggins deleted the fix/makefile-external-python branch February 4, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants