Skip to content

Implement ensureSpine for BitVector n as pack #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

lmbollen
Copy link
Member

@lmbollen lmbollen commented Apr 5, 2024

This enables us to deal with undefined BitVectors using the currently derived ensureSpine.

To satisfy ensureSpine (errorX "Undefined BitVector") == deepErrorX "Undefined BitVector"

Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry?

@lmbollen lmbollen force-pushed the ensure-spine-BitVector branch 2 times, most recently from a610da1 to 52d9ee9 Compare April 8, 2024 14:48
@lmbollen lmbollen requested a review from martijnbastiaan April 8, 2024 14:52
@lmbollen lmbollen force-pushed the ensure-spine-BitVector branch from 52d9ee9 to 257c6da Compare April 8, 2024 15:37
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requests on the xToBV stuff

@lmbollen lmbollen force-pushed the ensure-spine-BitVector branch from 257c6da to 407fd96 Compare April 9, 2024 07:01
@lmbollen lmbollen requested a review from martijnbastiaan April 9, 2024 07:01
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnbastiaan martijnbastiaan disabled auto-merge April 9, 2024 07:09
@lmbollen lmbollen force-pushed the ensure-spine-BitVector branch from 407fd96 to 0784c3b Compare April 9, 2024 07:13
@lmbollen lmbollen enabled auto-merge April 9, 2024 07:13
@lmbollen lmbollen force-pushed the ensure-spine-BitVector branch from 0784c3b to 372f04d Compare April 9, 2024 07:55
@lmbollen lmbollen disabled auto-merge April 9, 2024 07:56
@lmbollen lmbollen enabled auto-merge April 9, 2024 07:57
@lmbollen lmbollen merged commit a26bb9e into master Apr 9, 2024
11 checks passed
@lmbollen lmbollen deleted the ensure-spine-BitVector branch April 9, 2024 09:14
christiaanb added a commit that referenced this pull request Nov 2, 2024
Implement `ensureSpine` for `BitVector n` as `pack` (copy #2702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants