-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: add openjdk21 to projects file for diff report generation #821
Conversation
@nrmancuso ping. What blocks this? |
I think this will make diff report execution take too long/too much memory. I need to reevaluate this. We should probably just replace 17 with 21, if it’s one or the other. |
Only one jdk code is required for execution. Keep latest with exclusion on files that we can not parse yet. |
Agreed, they do a good job of keeping old inputs when possible, so we really shouldn’t miss anything by always using the latest version. |
I think this got missed please replace jdk17 with 21. As you said old inputs aren't removed so we won't miss it we just gain some new inputs related to the new syntax. why do we have this huge exclude list? |
Maybe we don't need this anymore with our new TreeWalker property :) |
Only one jdk code is required for execution, jdk17 can be removed. |
Exclude list is needed for no violation/exception runs. If we do those type of runs with those projects, then we need it. |
Closed in favor of #878 |
No description provided.