Skip to content

ENT-10961, CFE-1840: Added documentation on body fsattrs and the immutable constraint #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Mar 7, 2025

Ticket: ENT-10961, CFE-1840

Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add history.

Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo

@larsewi larsewi force-pushed the immutable branch 3 times, most recently from be36f82 to cea8867 Compare May 26, 2025 12:11
Ticket: ENT-10961, CFE-1840
Signed-off-by: Lars Erik Wik <[email protected]>
Co-authored-by: Nick Anderson <[email protected]>
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a question about what it means to clear the immutable bit multiple times.

Comment on lines +2794 to +2795
as short as possible. The immutable bit may be temporarily cleared multiple
times during a files promise.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean that it might be cleared multiple times during a files promise? Like cleared, re-applied, cleared, re-applied?

Copy link
Contributor Author

@larsewi larsewi May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that if you have a file promise that for example contains both the content and the perms attribute. Then the immutable bit may be temporarily cleared while changing the perms and reapplied afterwards. Later when replacing $(this.promiser) with $(this.promiser).cfnew (containing new content) it may again be temporarily cleared and reapplied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants