-
Notifications
You must be signed in to change notification settings - Fork 75
ENT-10961, CFE-1840: Added documentation on body fsattrs and the immutable constraint #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one typo
be36f82
to
cea8867
Compare
Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <[email protected]> Co-authored-by: Nick Anderson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but a question about what it means to clear the immutable bit multiple times.
as short as possible. The immutable bit may be temporarily cleared multiple | ||
times during a files promise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean that it might be cleared multiple times during a files promise? Like cleared, re-applied, cleared, re-applied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is that if you have a file promise that for example contains both the content
and the perms
attribute. Then the immutable bit may be temporarily cleared while changing the perms and reapplied afterwards. Later when replacing $(this.promiser)
with $(this.promiser).cfnew
(containing new content) it may again be temporarily cleared and reapplied.
Ticket: ENT-10961, CFE-1840