Skip to content

Adjusted configure.ac for finding workdir, logdir and piddir on windows platform #5683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Adjusted configure.ac for finding workdir, logdir and piddir on windows platform #5683

merged 1 commit into from
Jun 5, 2025
+3 −3

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Jan 22, 2025 •
edited
Loading

Ticket: ENT-12594
Changelog: none

Build Status

@craigcomstock craigcomstock marked this pull request as draft January 22, 2025 16:29
@craigcomstock
Copy link
Contributor Author

Will check if windows agents have any issues from before this change or if this is somehow ignored later in the build.

@craigcomstock
Copy link
Contributor Author

Build Status

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins please, platforms: mingw, packages only, no test (I know you don't understand all that, just thinking out loud what I might teach you someday)

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

[NO TESTS]

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11654/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11654/

@craigcomstock craigcomstock added the WIP Work in Progress label May 1, 2025
@craigcomstock
Adjusted configure.ac for finding workdir, logdir and piddir on windo…
f027c17 
…ws platform

Ticket: ENT-12594
Changelog: none
@craigcomstock craigcomstock marked this pull request as ready for review May 28, 2025 21:32
@craigcomstock
Copy link
Contributor Author

This does indeed fix core non-fatal "error looking" log statements but does not affect the code at all it seems, nor does it improve the output of cf-check on windows (still shows UNIX-style paths).

Don't see this anymore:

10:08:21 ./configure: line 13701: cmd: command not found
10:08:21 ./configure: line 13705: cmd: command not found
10:08:21 ./configure: line 13706: cmd: command not found

I will make similar changes to libntech and other repos as appropriate now.

@craigcomstock craigcomstock requested a review from larsewi May 28, 2025 21:33
@craigcomstock craigcomstock merged commit be91c2e into cfengine:master Jun 5, 2025
12 checks passed
@craigcomstock craigcomstock deleted the ENT-12594/master branch June 5, 2025 16:13
@craigcomstock craigcomstock added cherry-pick? Fixes which may need to be cherry-picked to LTS branches and removed cherry-pick? Fixes which may need to be cherry-picked to LTS branches labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsewi larsewi larsewi approved these changes

Assignees
No one assigned
Labels
WIP Work in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigcomstock @cf-bottom @larsewi