Skip to content

CFE-4499: Added asserts in aramid classes #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

victormlg
Copy link
Contributor

@victormlg victormlg commented Jun 10, 2025

I am not sure how many asserts we need here, and if it is enough to only have the in the class constructors

Ticket: CFE-4499
Signed-off-by: Victor Moene <[email protected]>
@victormlg victormlg marked this pull request as ready for review June 26, 2025 13:57
@victormlg victormlg requested review from larsewi June 26, 2025 13:57
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asserts look good to me. However, how does these asserts solve CFE-4499? Maybe you could add some more context to the commit message.

@olehermanse olehermanse merged commit 5382075 into cfengine:master Jun 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants