-
Notifications
You must be signed in to change notification settings - Fork 451
Ciup #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the testing configurations and dependency constraints to reflect support for newer Python and Django versions while removing older configurations. Key changes include:
- Updating tox.ini to support Python 3.7–3.9 with Django 1.11 and 2.2, and removing legacy Python 2.7 and older Django versions.
- Adjusting the celery version constraint and removing the Jython classifier in setup.py.
- Introducing a new GitHub Actions CI workflow with a revised test matrix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tox.ini | Updated envlist for Python 3.7–3.9 and Django 1.11/2.2; removed flake8 environment |
setup.py | Modified celery version constraint and removed the Jython classifier |
.github/workflows/ci.yml | Added new CI workflow configuration with a test matrix |
Comments suppressed due to low confidence (1)
setup.py:207
- The removal of the Jython classifier implies dropping Jython support. Confirm if this change reflects the intended support policy.
'Programming Language :: Python :: Implementation :: Jython',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request titled "Ciup" updates dependency version ranges and adjusts test configurations. Key changes include updating Python/Django environments in tox.ini, revising the celery dependency versions in setup.py and requirements/default.txt, and introducing a new GitHub Actions workflow for CI testing.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
tox.ini | Updated tox environment list; removed flake8 env configuration |
setup.py | Updated celery dependency version and removed Jython classifier |
requirements/default.txt | Revised celery version range to match updated dependency |
.github/workflows/ci.yml | Added a new CI workflow file with a test matrix for Python and Django versions |
Comments suppressed due to low confidence (2)
tox.ini:17
- The flake8 linting configuration has been removed; please ensure that linting is still performed through an alternative approach if this removal is intentional.
-[testenv:flake8]
.github/workflows/ci.yml:50
- The Django version values in the workflow matrix ('11' and '22') do not match the expected pattern ('1.11' and '2.2') as defined in tox.ini; consider aligning these to avoid environment mismatch issues.
TOXENV: py${{ matrix.python-version }}-django${{ matrix.django }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging as the CI is running
No description provided.