Skip to content

First set of French Translations #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MrMargouillat
Copy link

In this commit I created the string ressource for the French translation and started to translate the first ones.

@lagerspetz
Copy link
Member

Thank you!
I will also look at your bug report. I have a couple of concerns:
-translatable="false" means that the line should not be added to translated strings files. You can remove those lines from your strings file.
-You don't need to (and should not) copy English text to your translated strings file. It will show up in English if it has not yet been translated.

@lagerspetz
Copy link
Member

Oh, also samples are the measurements that carat takes from the device, so I am not sure "exemple" is the right word for that.

@MrMargouillat
Copy link
Author

Ok! Thank you, I'll do these changes right now. ;)

@MrMargouillat
Copy link
Author

Is it ok if I only comment them away? So I can use them to keep translating?

@lagerspetz
Copy link
Member

lagerspetz commented Oct 31, 2017 via email

@Raffaele74
Copy link
Contributor

Hi. probably samples >> échantillons

@MrMargouillat
Copy link
Author

Yes, but I'm not conviced neither buy "échantillons" , I'll just leave the blank for now...

@lagerspetz
Copy link
Member

How about mesures?

@MrMargouillat
Copy link
Author

Yes that it's it! xD Thanks I do add it. I'll leave all the other big texts translations for tomorrow.

@lagerspetz
Copy link
Member

Ok. Maybe I will keep this open, and merge when you feel it's done :)

@MrMargouillat
Copy link
Author

Oki ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants