Skip to content

fix: prevent slot availability when calendar services fail #21987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+4 −4
Closed

fix: prevent slot availability when calendar services fail #21987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e338948
fix: prevent slot availability when calendar services fail
devin-ai-integration[bot] Jun 23, 2025
4af0261
test: update isTimeslotAvailable test for fail-safe behavior
devin-ai-integration[bot] Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/features/bookings/Booker/utils/isTimeslotAvailable.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe("isTimeSlotAvailable", () => {
expect(result).toBe(false);
});

it("should return true when scheduleData is null", () => {
it("should return false when scheduleData is null (fail-safe behavior)", () => {
const slotToCheckInIso = "2024-02-08T10:30:00.000Z";
const quickAvailabilityChecks: QuickAvailabilityCheck[] = [];

Expand All @@ -37,7 +37,7 @@ describe("isTimeSlotAvailable", () => {
quickAvailabilityChecks,
});

expect(result).toBe(true);
expect(result).toBe(false);
});

it("should return true when the date doesn't exist in the schedule data", () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/features/bookings/Booker/utils/isTimeslotAvailable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ export const isTimeSlotAvailable = ({

if (isUnavailableAsPerQuickCheck) return false;

// If schedule is not loaded or other variables are unavailable consider the slot available
// If schedule is not loaded or other variables are unavailable, fail-safe to prevent double bookings
if (!scheduleData) {
return true;
return false;
}

const dateInGMT = isValidISOFormat(slotToCheckInIso) ? slotToCheckInIso.split("T")[0] : null;
Expand Down
Loading